vbhanuchander-lang commented on PR #17603:
URL: https://github.com/apache/iceberg/pull/17603#issuecomment-5518540496
Re-checked against `main` (`8ea7d00`) today: still `MERGEABLE`, 38 checks
green, no conflicts. This
closes #16003, which @abhishek593 filed against the `// TODO: direct
conversion from string to byte
buffer` that was already sitting in `SparkValueWriters.UUIDWriter`.
There is one decision here that needs a maintainer rather than more review
time, so to make it easy
to answer: **the new path is stricter than `UUID.fromString`.**
`UUID.fromString("1-2-3-4-5")` parses
today by zero-extending short groups; the byte-level parser accepts only
canonical 8-4-4-4-12, upper
or lower case. I chose strict because these bytes are persisted into a data
file, so a non-canonical
string would be written as a value the writer never really validated — but
it is a narrowing of
accepted input on a write path, and there is a test pinning whichever way
you want it.
If the lenient behaviour should be preserved exactly, say so and I will
change it in one commit. If
strict is right, this is ready.
@RussellSpitzer @pvary you have both merged in `api/util` and the Spark
writers recently — would one
of you be willing to make that call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
