kevinjqliu commented on code in PR #3832: URL: https://github.com/apache/iceberg-python/pull/3832#discussion_r3917273327
########## AGENTS.md: ########## @@ -62,6 +62,13 @@ lives under `pyiceberg/`, organized by concern rather than by engine: - Use existing test fixtures when possible. - We have a strong bias towards integration testing over mocks. Mocks should be avoided whenever possible and should only be used if similar, existing tests are using mocks. +### Required CI and Merge Queue + +- Keep the `required_status_checks.contexts` list in `.asf.yaml` synchronized whenever a required job/check is added, renamed, or removed. Each entry is a job/check context name, not a workflow filename. +- Verify that every required context reports for both `pull_request` and `merge_group`. Its producer workflow must run on both events. +- When a workflow uses an aggregate required job, such as `python-ci-required`, keep `if: always()` and its `needs` list in sync with every job whose result should block merging. +- Do not use `pull_request` path filters in workflows that produce required contexts. A skipped workflow does not report its required context, which blocks pull requests and causes Merge Queue entries to time out. + Review Comment: added some rules here so agents can understand the links between files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
