dhruvarya-db opened a new pull request, #3133: URL: https://github.com/apache/iceberg-rust/pull/3133
Reviving #2392, which added these tests but was auto-closed as stale. Most of the per-action tests in `transaction/mod.rs` only check the `ActionCommit` an action produces. Fast-append is already exercised end-to-end through a catalog (see `test_transaction_snapshot_summary` and `test_fast_append_with_row_lineage`), but the property, location, and multi-action paths don't have that kind of round-trip coverage yet. This adds it. ## Which issue does this PR close? Part of #1322. ## What changes are included in this PR? A new `test_commit_against_memory_catalog` module, built on the existing `make_v3_minimal_table_in_catalog` helper, covering: * setting properties and reading them back after commit * updating the table location * chaining a property update and a location update, and checking it lands as a single metadata-log entry rather than two separate commits * a chained transaction whose last action is invalid, checking the whole commit is rejected and the catalog is left untouched The last two also fold in @andybradshaw's review feedback from #2392 (asserting the chained update is a single commit via the metadata-log length, and adding the failing-transaction case). ## Are these changes tested? They are the tests. Ran them locally with `cargo test -p iceberg`; fmt and clippy are clean too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
