subhramit commented on PR #17770: URL: https://github.com/apache/iceberg/pull/17770#issuecomment-5498281086
> What are the benefits of doing this? Seems like we are just more explicitly including JUnit4 and maybe avoiding some other dependencies that Flink test libraries were bringing in by default. Umm so this moves JUnit4 off the compile classpath. The primary benefit I see is that currently `junit:junit` comes in transitively through `flink-test-utils` / `flink-connector-test-utils` as a compile-visible test dependency, so a new test could import `org.junit.Test` or use `@Rule` and it would compile. If we are making it `runtimeOnly`, new JUnit4 tests cannot be added by accident. The vintage engine is also removed which was on the test runtime classpath but had nothing to run as there are no JUnit4 tests left under `flink/`. `junit-vintage-engine` will no longer resolve, so the JUnit Platform cannot discover or run JUnit4 tests at all. On top of that, the explicit `flink-test-utils-junit` declaration only existed to hold an exclusion, and `flink-test-utils` already pulled the module in transitively, so cleaned it up and its `libs.versions.toml` aliases as well. Seeing the good first issue label, I didn't expect much myself and primarily wanted to start exploring the codebase and its build system for future contributions. If you think this doesn't add sufficient value, do feel free to close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
