RussellSpitzer commented on PR #15989: URL: https://github.com/apache/iceberg/pull/15989#issuecomment-5497286570
So if I get this correctly, we are doing this fix to make sure that path's are encoded with %20 and not +. (There are 2 other characters I see we are covering but they are also ... very unlikely to really be used) The worry is that we may have clients sending "+" that mean "+" and will get decoded differently on server side if the server changes it's decoder? Is that right @nastra ? Honestly the surface area is so small I'm not that worried about broken folks. From the table @adutra posted we are already broken if you are using multiple implementations with your catalog correct? The Python version and the Java client are currently in agreement as are Go and Rust. The fact that this is coming up so rarely does make me think we should just go compliant with the RFC in Java and convince the Python impl to do the same. Does this fix come from a real user who broke on this? I'm just wondering what kind of names they were using -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
