kinolaev commented on code in PR #17868:
URL: https://github.com/apache/iceberg/pull/17868#discussion_r3892760063


##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -2246,14 +2246,29 @@ public void testRewriteDataFilesPreservesLineage() 
throws NoSuchTableException {
   public void testExecutorCacheForDeleteFilesDisabled() {
     Table table = createTablePartitioned(1, 1);
     RewriteDataFilesSparkAction action = 
SparkActions.get(spark).rewriteDataFiles(table);
+    action.execute();

Review Comment:
   I think we should decide which tests to keep - the ones in 
`TestRewriteDataFilesSparkAction` or `TestSparkExecutorCache`. I'm in favor of 
`TestRewriteDataFilesSparkAction`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to