laskoviymishka opened a new pull request, #1980:
URL: https://github.com/apache/iceberg-go/pull/1980
The negative-width test case ("negative width keeps bound") was added in
#1934 while the stricter truncation-invariant guard was added in #1928. Each PR
was green on its own base, but the rebase-merge combined them: the guard
`tt.truncate < len(tt.value)` matches a negative width (-1 < 2), so the
negative case (where the bound is kept, not truncated) wrongly falls into the
truncation asserts and fails deterministically:
utils_test.go:128: "2" is not less than or equal to "-1"
utils_test.go:129: "0" is not greater than "0"
Only assert the shrink/increment invariants when a truncation actually
happened by additionally requiring a non-negative width. The production
TruncateUpperBoundBinary already handles negative widths correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
