ebyhr opened a new pull request, #17888: URL: https://github.com/apache/iceberg/pull/17888
The dependabot bump of Guava 33.6.0 → 33.7.1 broke compilation: ``` Error: /home/runner/work/iceberg/iceberg/core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:34: error: cannot find symbol import org.apache.iceberg.relocated.com.google.common.collect.Queues; ``` `iceberg-bundled-guava` shades Guava via `shadowJar` + `minimize()`. Since that module has no consumers on its own classpath, `minimize()` only keeps a class if something else inside Guava still references it. `Queues` survived only because `MoreExecutors` called `Queues.newLinkedBlockingQueue()` internally. Guava 33.7.x replaced that internal call with `new LinkedBlockingQueue<>()`, so `minimize()` now sees `Queues` as unused and strips it even though `core`, `flink`, and `spark` call it directly at runtime. Excluding `guava` from `minimize()` keeps `Queues`, but also restores unrelocated `com.google.thirdparty.publicsuffix.*` classes. This PR removes the dependency on the shaded [Queues](https://github.com/google/guava/blob/master/guava/src/com/google/common/collect/Queues.java) helper entirely. Its methods are one-line wrappers around JDK constructors: - Queues.newConcurrentLinkedQueue() → new ConcurrentLinkedQueue<>() - Queues.newArrayDeque() → new ArrayDeque<>() Closes #17882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
