gimgit commented on PR #17504: URL: https://github.com/apache/iceberg/pull/17504#issuecomment-5461105465
Rebased on main after #16827. The `min-overlap-depth` guard now also rejects Hilbert: the Hilbert runner shares the shuffling planner with zorder, so the option would have leaked into curve-based rewrites. It is now accepted only for a plain column sort order that matches the table sort order — a rewrite on a different key would leave the overlap on the table key in place and select the same files on every run. Tests cover zorder, hilbert and the mismatched order. @RussellSpitzer flagging since this touches the interaction with your Hilbert change. @anuragmantri both review threads were addressed in the previous push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
