nssalian commented on issue #1929: URL: https://github.com/apache/iceberg-go/issues/1929#issuecomment-5458176904
Thanks for starting this @tanmayrauth. > Precisely! I agree completely here. My preference would actually be to add the Java-authored bytes and integration test strategy into apache/iceberg-verification and then just add it as a submodule here to use (similar to how github.com/apache/arrow-go uses github.com/apache/arrow-testing and github.com/apache/parquet-testing submodules with test files) Agreed. Long term this would be great to have in the `iceberg-verification`. That repo is just getting kicked off and we are putting the initial artifacts in as we speak. To unblock your work here, Tanmay, you could follow the integration + test data setup like we have for geo and variant in this repo. Feel free to refer to this: https://github.com/apache/iceberg-go/pull/1238/. If you are able to get a roundtrip verification here with integration tests, that would be a great place to start and then port over as needed into the verification repo. > On testing: yep, cloning the DV setup: Java-authored bytes checked in as testdata, unit tests with no JVM in CI Let's be careful to not add a lot of files but a qualitative sample would suffice. I added only a handful of shredded variant cases from a bunch in parquet testing so we cover the cases while being compact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
