singhpk234 commented on code in PR #17851:
URL: https://github.com/apache/iceberg/pull/17851#discussion_r3883144017
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -348,6 +362,9 @@ void update(ContentFile<?> file, Snapshot snapshot) {
case POSITION_DELETES:
this.posDeleteRecordCount += file.recordCount();
this.posDeleteFileCount += 1;
+ if (file.format() == FileFormat.PUFFIN) {
+ this.dvCount += 1;
+ }
Review Comment:
i see, that make sense, we should add a test for this scenario to make sure
we never double count !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
