xanderbailey commented on code in PR #3091:
URL: https://github.com/apache/iceberg-rust/pull/3091#discussion_r3879455088
##########
crates/iceberg/src/spec/values/literal.rs:
##########
@@ -55,6 +57,132 @@ pub enum Literal {
Map(Map),
}
+#[derive(SerializeDerive, DeserializeDerive)]
+#[serde(tag = "type", content = "value", rename_all = "kebab-case")]
+enum SerializableLiteral {
+ Boolean(bool),
+ Int(i32),
+ Long(i64),
+ Float([u8; 4]),
+ Double([u8; 8]),
+ String(String),
+ Binary(Vec<u8>),
+ Int128([u8; 16]),
+ UInt128([u8; 16]),
Review Comment:
`UInt128 serializes as "u-int128"` with `kebab-case`, doesn't really matter
too much bit it's not very pretty IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
