pvary commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r3879292927


##########
data/src/test/java/org/apache/iceberg/data/ReadFormatModelTests.java:
##########
@@ -1343,7 +1347,7 @@ void testReadMetadataColumnRowPosition(FileFormat 
fileFormat) throws IOException
   @ParameterizedTest
   @FieldSource("FILE_FORMATS")
   void testReadMetadataColumnIsDeleted(FileFormat fileFormat) throws 
IOException {
-
+    assumeFalse(supportsBatchReads(), "DeletedColumnVector requires a delete 
filter");

Review Comment:
   Please provide a better message. `DeletedColumnVector` is Spark specific.
   What is the exact issue here? The batch readers doesn't read the DVs either, 
so checking false seems ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to