fallintoplace opened a new pull request, #1919: URL: https://github.com/apache/iceberg-go/pull/1919
## What changed - Reuse one `[]int` scratch slice while sorting field IDs for the six stats maps written by the files metadata table. - Keep deterministic sorted keys and the existing validation. ## Benchmark - **Machine:** Apple M1 Pro, darwin/arm64 - **Go:** go1.26.3 - **Command:** `go test ./table -run '^$' -bench '^BenchmarkInspectContentFileAppenderDataFileStats/files=(4096|16384)/stats=(32|128)/(borrowed|public)$' -benchmem -count=5 -benchtime=1s` - **Representative borrowed-data results (median of 5 runs):** | case | ns/op | B/op | allocs/op | | --- | ---: | ---: | ---: | | 4096 files / 32 stats | 42,162,059 -> 40,548,478 | 49,853,388 -> 43,561,937 (**12.6% less**) | 54,222 -> 29,646 (**45.3% fewer**) | | 16384 files / 128 stats | 707,448,646 -> 727,017,084 | 773,116,304 -> 672,455,176 (**13.0% less**) | 312,525 -> 214,226 (**31.5% fewer**) | Runtime varied between runs, while the allocation reduction was consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
