dbtsai commented on PR #17236: URL: https://github.com/apache/iceberg/pull/17236#issuecomment-5441993776
Hi @liurenjie1024, apologies for the delay — I've been swamped and let this go stale. I've reopened it and will drive it to merge. Thanks for the careful review and for pushing to move it forward! On your three points: 1. **Aliyun/Dell test compilation** — resolved by scoping: I've dropped the Aliyun (OSS) and Dell (ECS) changes so this PR now focuses only on AWS, GCP, and Azure. The failing test helpers are gone. 2. **`readTail` counting an operation at EOF** — fixed. `readOperations.increment()` is now inside the `bytesRead > 0` guard, and I added an analytics-core empty-tail regression test. 3. **Zero-length vectored ranges** — fixed. Both counters are now guarded with `range.length() > 0`, consistent with the new `readFully` handling, with a regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
