fallintoplace opened a new pull request, #1915: URL: https://github.com/apache/iceberg-go/pull/1915
## What changed - **Use `dataFilePartition`** when building the positional-delete index. - **Use the borrowed view for data-file lookups** when matching partition-scoped deletes. - **Keep the public fallback** for other `DataFile` implementations. - **Add regression coverage** for the borrowed accessor. - **Add a before/after benchmark** with 10,000 files and wide partitions. ## Benchmark Command: `go test ./table -bench=BenchmarkPositionalDeletePartitionKey -benchmem -benchtime=200ms -count=5` Machine: Apple M1 Pro, darwin/arm64 Median of 5 runs: | case | before | after | before B/op | after B/op | before allocs/op | after allocs/op | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | 1 int32 field | 2.54 ms | 1.42 ms | 2.96 MB | 0.40 MB | 50,000 | 30,000 | | 8 int32 fields | 5.99 ms | 4.37 ms | 6.62 MB | 4.06 MB | 90,000 | 70,000 | | 32 binary fields | 62.45 ms | 37.25 ms | 90.88 MB | 59.28 MB | 790,000 | 110,000 | ## Tests - `go test ./table -count=1` - `go vet ./table` - `go test ./... -count=1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
