Copilot commented on code in PR #3083:
URL: https://github.com/apache/iceberg-rust/pull/3083#discussion_r3871283623
##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -681,7 +681,7 @@ pub(crate) mod _serde {
.ok_or_else(|| {
invalid_err_with_reason(
"record",
- &format!("field {} is not exist",
&field_name),
+ &format!("field {} is not exist",
field_name),
Review Comment:
The error message grammar is incorrect (\"is not exist\"). This is
user-visible and should be changed to a clearer phrasing like \"field
'{field_name}' does not exist\" (or similar), keeping the same information
while improving readability.
##########
crates/iceberg/src/spec/manifest_list/mod.rs:
##########
@@ -196,7 +196,7 @@ mod test {
existing_rows_count: Some(0),
deleted_rows_count: Some(0),
partitions: Some(
- vec![FieldSummary { contains_null: false,
contains_nan: Some(false), lower_bound:
Some(Datum::float(1.1).to_bytes().unwrap()), upper_bound:
Some(Datum::float(2.1).to_bytes().unwrap())}]
+ vec![FieldSummary { contains_null: false,
contains_nan: Some(false), lower_bound:
Some(Datum::float(1.1_f32).to_bytes().unwrap()), upper_bound:
Some(Datum::float(2.1_f32).to_bytes().unwrap())}]
Review Comment:
This line is extremely long and hard to scan in reviews/debugging. Consider
formatting the `FieldSummary` struct literal across multiple lines (and
similarly for the other occurrence in this file) to improve readability and
reduce future diff noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
