szehon-ho commented on code in PR #17451:
URL: https://github.com/apache/iceberg/pull/17451#discussion_r3869735496
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -99,6 +99,18 @@ default String location() {
/** Returns if collected, map from column ID to value upper bounds, null
otherwise. */
Map<Integer, ByteBuffer> upperBounds();
+ /**
+ * Returns if collected, map from column ID to its average value size in
memory (uncompressed) in
+ * bytes over non-null values, null otherwise.
+ *
+ * <p>This value is only observable before the file is written: it survives
{@link #copy()} and
+ * Java serialization, but a v1-v3 manifest round trip drops it, since it
has no position in the
+ * manifest schema.
Review Comment:
```suggestion
* <p>This statistic is not persisted in manifests prior to v4, so it is
generally only present
* on newly created or written files, and is null for files read back from
such manifests.
```
Keep the caveat about when the value is observable, but drop the `BaseFile`
internals (Java serialization survival, "no position in the manifest schema") —
those are implementation details rather than part of the `ContentFile`
interface contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
