anoopj commented on code in PR #3058:
URL: https://github.com/apache/iceberg-rust/pull/3058#discussion_r3867428170
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -421,6 +467,25 @@ impl FileScanTaskReader {
};
}
+ if project_row_id {
+ // A name-only physical `_row_id` can't be threaded (synthesis
keys the physical
+ // leaf by its reserved field id), and no conformant writer emits
it, so reject
+ // it -- regardless of `first_row_id`, since it never threads
either way.
+ if row_id_present_by_name_only {
Review Comment:
That sounds good. I gated the reject on presence of `first_row_id`, matching
the `_lusn` guard. This is consistent to what the Java implementation does
also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
