rambleraptor commented on code in PR #3858:
URL: https://github.com/apache/iceberg-python/pull/3858#discussion_r3865654781
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -594,6 +594,8 @@ def _copy_with_new_status(entry: ManifestEntry, status:
ManifestEntryStatus) ->
existing_manifests = []
total_deleted_entries = []
partial_rewrites_needed = False
+ # Preserve files explicitly requested via delete_data_file() before
resetting.
Review Comment:
This seems reasonable.
##########
tests/table/test_delete_data_file_on_delete_files.py:
##########
@@ -0,0 +1,257 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Can you consolidate these tests into
https://github.com/apache/iceberg-python/blob/main/tests/table/test_snapshots.py?
This is where the rest of the snapshot tests live.
##########
tests/table/test_delete_data_file_on_delete_files.py:
##########
@@ -0,0 +1,257 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Regression tests for delete_data_file() on _DeleteFiles instances.
+
+_DeleteFiles is primarily predicate-driven, but it inherits delete_data_file()
+from _SnapshotProducer. These tests verify that explicit file references are
+honoured correctly in all combinations with predicate-based deletion.
+"""
+
+import pyarrow as pa
+import pytest
+
+from pyiceberg.catalog import Catalog
+from pyiceberg.expressions import EqualTo
+from pyiceberg.schema import Schema
+from pyiceberg.table import Table
+from pyiceberg.types import LongType, NestedField
+
+
[email protected]()
Review Comment:
Can we reuse existing fixtures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
