DmitryKotuseu commented on issue #1876:
URL: https://github.com/apache/iceberg-go/issues/1876#issuecomment-5420854082

   @Revanth14. Please go ahead - I won't have time to take it, and I'd rather 
not hold it up.
   Two things that might help:
   The reproducer covers the spec-conformant case, where the Iceberg field is 
decimal(9,0) and the file stores it as INT32 with Decimal(9,0). The case we 
actually hit in the wild narrows the logical type as well: the Iceberg schema 
says decimal(38,0) and Snowflake writes physical=INT32 
logical=Decimal(precision=3, scale=0). Worth a second test case, since that's 
the shape a real writer produces, and it's the one where the scale has to be 
taken from the Parquet logical type rather than assumed to match the field.
   If part 1 of the suggested fix (drop the bounds and fall back to 
rowsMightMatch) is easier to land on its own, that alone restores correctness - 
pruning can follow separately.
   Happy to test a PR against the live Snowflake Open Catalog table where we 
found this, which is the one case that can't be reproduced locally. Just ping 
me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to