dramaticlly commented on code in PR #17763:
URL: https://github.com/apache/iceberg/pull/17763#discussion_r3859530181
##########
core/src/main/java/org/apache/iceberg/FileCleanupStrategy.java:
##########
@@ -84,6 +84,7 @@ public abstract void cleanFiles(
ManifestFile.schema(),
ImmutableSet.of(
ManifestFile.PATH.fieldId(),
+ ManifestFile.MANIFEST_CONTENT.fieldId(),
Review Comment:
Thanks @szehon-ho , added UT as suggested for coverage on
`MANIFEST_PROJECTION`.
Unlike existing UT, we do need to create a package private
ReachableFileCleanup and calling protected method to exercise the projection
logic. Also improve the coverage on v3 and v4 format in TestRemoveSnapshots.
Credit to @dkranchii for identifying this problem first in #17745 and #17772
adds the V3 parameterization in TestRemoveSnapshots, I added him as coauthor in
the rebased commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
