qzyu999 commented on PR #3818: URL: https://github.com/apache/iceberg-python/pull/3818#issuecomment-5420025134
Nice fix! While reviewing this I noticed a related pre-existing gap: `_DeleteFiles` (the `update_snapshot().delete()` path) exposes `delete_data_file()` from its parent class, but calling it silently does nothing because `_compute_deletes` resets `self._deleted_data_files = set()` before scanning by predicate. This means `_OverwriteFiles` correctly validates explicit deletes (thanks to this PR), but `_DeleteFiles` silently drops them. Filed as #3857 with a reproduction script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
