jkasireddy commented on PR #3757: URL: https://github.com/apache/iceberg-python/pull/3757#issuecomment-5419964766
@renaudb Should we use Iceberg's PARQUET_BLOOM_FILTER_COLUMN_FPP_DEFAULT here when the column is enabled but no explicit FPP is configured? Iceberg documents the default as 0.01, while PyArrow's bloom_filter_options defaults to 0.05 when fpp is omitted. As written, write.parquet.bloom-filter-enabled.column.foo=true without an FPP property appears to produce different behavior from the Iceberg default. It might also be worth adding a regression test for the enabled-with-default-FPP case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
