hedger9487 commented on PR #3846: URL: https://github.com/apache/iceberg-python/pull/3846#issuecomment-5419627930
Good catch! @ebyhr The previous test was failing early in `load_table` (which already had the type filter applied during requirement checking), before ever reaching the SQL `UPDATE` statement. I have updated `test_commit_table_ignores_view_rows` to simulate the concurrent modification race condition (where `load_table` succeeded prior to the row becoming a `VIEW`). Now, if the `type_filter` in `commit_table`'s SQL `UPDATE` is reverted, the test fails with `DID NOT RAISE CommitFailedException` as expected. Thanks for pointing this out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
