shoemoney opened a new pull request, #17817: URL: https://github.com/apache/iceberg/pull/17817
Fix unresolved credentials endpoint in S3FileIO credential refresh. Bug: refreshStorageCredentials creates VendedCredentialsProvider with raw properties. When credentials.uri is a relative path, it stays unresolved and results in null or a failed fetch at S3FileIO.java:464. Fix: copy properties, resolve the endpoint with RESTUtil.resolveEndpoint(uri, refreshEndpoint) using CatalogProperties.URI and VendedCredentialsProvider.URI, put the resolved value back as credentials.uri, then create the provider. Evidence: verified diff is minimal and matches AwsClientProperties and GCPProperties resolve pattern. Manual verification shows the endpoint is now absolute before provider creation. Existing TestS3FileIOCredentialRefresh covers the refresh path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
