dramaticlly commented on code in PR #17812:
URL: https://github.com/apache/iceberg/pull/17812#discussion_r3856786257
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -158,7 +158,7 @@ protected ManifestReader(
} else {
LOG.warn(
"Reading partition spec from manifest file metadata is deprecated
and will be "
- + "removed in the 1.12.0 release. Pass specsById to avoid
reading from file metadata: {}",
+ + "removed in the 2.0.0 release. Pass specsById to avoid reading
from file metadata: {}",
Review Comment:
@RussellSpitzer I updated the warning log message to 2.0 as today
https://github.com/apache/iceberg/blob/b1c6cf839d1927f4e474cc7f418381a36050ac74/core/src/main/java/org/apache/iceberg/BaseSnapshot.java#L276
still pass a null specById. Given class of baseSnapshot does not have a way to
access specById directly from table metadata, it will continue to use the
fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
