hedger9487 commented on PR #3842: URL: https://github.com/apache/iceberg-python/pull/3842#issuecomment-5415033269
Thanks for the thoughtful feedback @rambleraptor! I have updated the PR accordingly: 1. **Default behavior**: Writes `int` (`IntegerType`) for `equality_ids` per the Iceberg spec. 2. **Backwards compatibility flag**: Added `write.manifest.legacy-long-equality-ids` table property and `legacy_equality_ids: bool = False` parameter in `write_manifest` / `ManifestWriter` so users who require legacy long `equality_ids` during migration can still opt in. 3. **Deprecation warning & logging**: Emits a `DeprecationWarning` when reading manifests with legacy `long` equality_ids, informing users that long equality_ids are non-compliant and that support will be dropped in a future release. 4. Added comprehensive unit tests covering both the deprecation warning on read and the legacy write config option. All tests pass cleanly. Ready for another review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
