Copilot commented on code in PR #3851:
URL: https://github.com/apache/iceberg-python/pull/3851#discussion_r3850673756
##########
.github/workflows/svn-build-artifacts.yml:
##########
@@ -36,7 +36,11 @@ jobs:
strategy:
max-parallel: 15
matrix:
- os: [ ubuntu-latest, ubuntu-24.04-arm, windows-latest, macos-15-intel,
macos-latest ]
+ os: [ ubuntu-latest, ubuntu-24.04-arm, windows-latest, windows-11-arm,
macos-15-intel, macos-latest ]
+ include:
+ - os: windows-11-arm
+ before_test: "uv pip install pytest==9.1.1"
+ test_command: "python -m pytest --confcutdir={project}/tests/avro
{project}/tests/avro/test_decoder.py"
Review Comment:
The matrix currently lists `windows-11-arm` in `matrix.os` and also adds an
`include` entry with `os: windows-11-arm`. In GitHub Actions, `include` adds an
extra matrix row rather than augmenting an existing one, so this will schedule
two `windows-11-arm` jobs (one without `before_test` / `test_command`). Remove
`windows-11-arm` from the `os` list (or add an `exclude` for it) so only the
customized row runs.
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -36,7 +36,11 @@ jobs:
strategy:
max-parallel: 15
matrix:
- os: [ ubuntu-latest, ubuntu-24.04-arm, windows-latest, macos-15-intel,
macos-latest ]
+ os: [ ubuntu-latest, ubuntu-24.04-arm, windows-latest, windows-11-arm,
macos-15-intel, macos-latest ]
+ include:
+ - os: windows-11-arm
+ before_test: "uv pip install pytest==9.1.1"
+ test_command: "python -m pytest --confcutdir={project}/tests/avro
{project}/tests/avro/test_decoder.py"
Review Comment:
The matrix currently lists `windows-11-arm` in `matrix.os` and also adds an
`include` entry with `os: windows-11-arm`. In GitHub Actions, `include` adds an
extra matrix row rather than augmenting an existing one, so this will schedule
two `windows-11-arm` jobs (one without `before_test` / `test_command`). Remove
`windows-11-arm` from the `os` list (or add an `exclude` for it) so only the
customized row runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
