adonm commented on PR #3830: URL: https://github.com/apache/iceberg-python/pull/3830#issuecomment-5404870797
Synced with latest main (now 13 commits ahead of the original base, including the pyarrow 24→25 upgrade). pyarrow 25 deprecated the SortOptions-level `null_placement` argument (per-key null placement was added in Arrow 25 / GH-46926), and the project's pytest config promotes warnings to errors, so the original `pc.sort_indices(..., null_placement=...)` call started failing against the new base. Fixed with a version-aware call and tightened the annotations so strict mypy stays clean (zero new errors vs main). Verified locally: unit test, docker-based REST catalog integration test (`test_write_identity_sort_order`), ruff, and mypy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
