anoopj commented on code in PR #17541:
URL: https://github.com/apache/iceberg/pull/17541#discussion_r3848310778
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -258,7 +260,18 @@ Builder scanMetrics(ScanMetrics newScanMetrics) {
return this;
}
+ /** Sets the deletion vector that marks manifest entries deleted by
position. */
+ Builder manifestDv(ByteBuffer dv) {
+ this.manifestDv = dv;
+ return this;
+ }
+
V4ManifestReader build() {
+ if (manifestDv != null) {
Review Comment:
Until we implement MDV, the rejection has to be done somewhere. The initial
version of the PR had it done in the scan task planner: this is moving the
rejection to the correct place (reader)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
