mattfaltyn opened a new pull request, #3062: URL: https://github.com/apache/iceberg-rust/pull/3062
## Which issue does this PR close? - Closes #3061. ## What changes are included in this PR? - Propagate transaction commit failures from the SQL catalog's shared `execute` helper. - Preserve the existing statement-error behavior while preventing rolled-back catalog mutations from being reported as successful. - Add a SQLite regression test using a deferred foreign-key violation to prove that commit-time errors reach callers and successful commits still work. ## Are these changes tested? Yes: - `cargo test -p iceberg-catalog-sql test_execute_returns_commit_error -- --nocapture` - `cargo test -p iceberg-catalog-sql --lib --all-features` - `make check` - `SSL_CERT_FILE=/etc/ssl/cert.pem make unit-test` - `SSL_CERT_FILE=/etc/ssl/cert.pem ICEBERG_TEST_HMS_ENDPOINT=127.0.0.1:9083 make nextest` (2,111 tests passed) ## AI Disclosure AI assistance was used to audit the SQL catalog call paths, draft the issue, implement the focused fix and regression test, and review the final contribution. I independently reproduced the failure, traced the affected behavior, reviewed the diff, and ran the validation listed above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
