wgtmac commented on PR #867: URL: https://github.com/apache/iceberg-cpp/pull/867#issuecomment-5397862652
I've made some changes to this PR. The intention is to be more Java-like so future feature catch-up and review will be much easier. - `HttpClient` now uses `std::shared_ptr` through the auth flow. The session can refresh in the background, so it must keep the client alive. - `OAuth2Session` is now a separate internal class. - Token expiry now follows Java. JWT `exp` takes precedence. Otherwise, expiry is based on the token request start time plus `expires_in`. - `OAuth2Util` is now a class so we are able to have internal functions. - I updated the related unit and integration tests by removing meaningless cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
