rdblue commented on code in PR #17343:
URL: https://github.com/apache/iceberg/pull/17343#discussion_r3832389322
##########
api/src/main/java/org/apache/iceberg/expressions/Expressions.java:
##########
@@ -317,6 +318,49 @@ public static <T> UnboundTerm<T> transform(String name,
Transform<?, T> transfor
return new UnboundTransform<>(ref(name), transform);
}
+ /**
+ * Create a reference to a function by name, in the catalog of the
referencing object.
Review Comment:
I'm assuming that this is not going to parse the name in any way? If so, I'd
like to see that noted here. I also think it is probably better to define this
as `String...` so that you can capture multiple parts. Then the semantics are
clear that you can pass a single name, but it won't be parsed (because it's
easy to pass additional parts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
