Guosmilesmile commented on PR #17737: URL: https://github.com/apache/iceberg/pull/17737#issuecomment-5364730211
@nssalian I double-checked this, and the generic-reader cross-check is already covered by the format model TCK. BaseFormatModelTests.testDataWriterEngineWriteGenericRead writes data using the engine writer registered in FlinkFormatModels (FlinkAvroWriter) and reads it back as generic Records. The test is parameterized over FORMAT_AND_GENERATOR, which includes (AVRO, Variant), so the bytes produced by the writer are already validated against an independent implementation. The same cross-check is also covered for Spark via TestSparkFormatModel. In fact, this PR fixes the previously failing case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
