JosephLenton commented on code in PR #2937:
URL: https://github.com/apache/iceberg-rust/pull/2937#discussion_r3822362882
##########
crates/iceberg/src/transaction/action.rs:
##########
@@ -34,7 +34,7 @@ pub(crate) type BoxedTransactionAction = Arc<dyn
TransactionAction>;
/// Each action is responsible for generating the updates and requirements
needed
/// to modify the table metadata.
#[async_trait]
-pub(crate) trait TransactionAction: AsAny + Sync + Send {
+pub trait TransactionAction: AsAny + Sync + Send {
Review Comment:
Cheers for taking a look @dannycjones .
Your suggestion makes sense. I’m on holiday this week, and can look at
getting rebased and merged next week when I’m back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
