chiragkava commented on issue #17722: URL: https://github.com/apache/iceberg/issues/17722#issuecomment-5352285798
Hi @waterWang thanks for taking the time to contribute a fix . Unfortunately I don't think this fixes the leak as reported. Releasing the cached vector in ColumnVector.close() only helps if something calls close(). but nothing in the arrow read path ever does: the module never invokes ColumnarBatch.close(), and the ArrowReader javadoc explicitly tells callers not to hold or close batches. So the decoded vector still leaks once per batch. There's also an ownership issue. I already had an inprogress PR with test case so i have linked the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
