varun-lakhyani commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3818522845
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -283,6 +301,19 @@ public static RewriteResult<ManifestFile>
rewriteManifestList(
mf.path(),
sourcePrefix));
+ long unmeasured =
Review Comment:
Yeah I missed an important thing earlier - That precondition never belonged
in function t**hat's called per snapshot** , when both Map and set used in it
were **global (same everytime)**. It always checked the exact same thing for
each snapshot.
Agreed to remove set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
