amogh-jahagirdar commented on code in PR #17728:
URL: https://github.com/apache/iceberg/pull/17728#discussion_r3818223214
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -84,6 +84,14 @@ public static TableMetadata newTableMetadata(
return newTableMetadata(schema, spec, SortOrder.unsorted(), location,
properties);
}
+ public static void checkFormatVersionCompatibility(
Review Comment:
I don't think I'd add this public utility, at least for now, until we really
have multiple callers, and know what appropriate input would be for a whole
"formatVersionCompatibility" check. Right now it's just doing schema and
properties, and Schema.checkCompatibility is doing the heavy lifting, and the
properties is only used to extract the format version.
Think I'd reccomend just inlining this above in the
RestSessionCatalog#create call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
