ebyhr commented on code in PR #17735:
URL: https://github.com/apache/iceberg/pull/17735#discussion_r3817616229
##########
core/src/test/java/org/apache/iceberg/TestScansAndSchemaEvolution.java:
##########
@@ -317,6 +318,26 @@ public void testColumnDrop() throws IOException {
assertThat(tasks).hasSize(2);
}
+ @TestTemplate
+ void plansBranchSnapshotWhenMainIsEmptyAfterSchemaEvolution() throws
IOException {
+ Table table = TestTables.create(temp, "test", SCHEMA, SPEC, formatVersion);
+
+
table.newAppend().appendFile(createDataFile("one")).toBranch("branch").commit();
+ long snapshotId = table.snapshot("branch").snapshotId();
Review Comment:
nit: We could rename the variable to `branchSnapshotId` to make its usage
clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
