anoopj commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r3817564339


##########
core/src/main/java/org/apache/iceberg/encryption/EncryptionUtil.java:
##########
@@ -140,19 +141,33 @@ public static ByteBuffer setFileLength(ByteBuffer 
keyMetadata, long fileLength)
    * @param manifestList a ManifestListFile
    * @param em the table's EncryptionManager
    * @return a decrypted key metadata buffer
+   * @deprecated since 1.12.0. Will be removed in 1.13.0; use {@link
+   *     #decryptKeyMetadata(EncryptedFile, EncryptionManager)} instead.
    */
+  @Deprecated
   public static ByteBuffer decryptManifestListKeyMetadata(
       ManifestListFile manifestList, EncryptionManager em) {
+    return decryptKeyMetadata(manifestList, em);
+  }
+
+  /**
+   * Decrypt the key metadata of an encryptable file.
+   *
+   * @param file an EncryptableFile

Review Comment:
   Agree



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to