nssalian commented on code in PR #1846:
URL: https://github.com/apache/iceberg-go/pull/1846#discussion_r3816429262
##########
table/internal/variant_shredding.go:
##########
@@ -47,17 +47,6 @@ var decimalPriority = map[variant.Type]int{
variant.Decimal4: 0, variant.Decimal8: 1, variant.Decimal16: 2,
}
-// tieBreakPriority breaks count ties in most-common-type selection; higher
wins.
-// Types absent here (Null, Array, Object) resolve to -1.
-var tieBreakPriority = map[variant.Type]int{
- variant.Bool: 0, variant.Int8: 1, variant.Int16: 2, variant.Int32: 3,
- variant.Int64: 4, variant.Float: 5, variant.Double: 6,
variant.Decimal4: 7,
- variant.Decimal8: 8, variant.Decimal16: 9, variant.Date: 10,
variant.Time: 11,
- variant.TimestampMicros: 12, variant.TimestampMicrosNTZ: 13,
variant.Binary: 14,
- variant.String: 15, variant.TimestampNanos: 16,
variant.TimestampNanosNTZ: 17,
- variant.UUID: 18,
-}
-
type fieldInfo struct {
typeCounts map[variant.Type]int
Review Comment:
Also done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
