yangshangqing95 commented on code in PR #17714:
URL: https://github.com/apache/iceberg/pull/17714#discussion_r3816315128
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -509,6 +509,25 @@ public void
allManifestsTablePreservesSnapshotPruningWhenIgnoringResiduals() thr
validateTaskScanResiduals(scan, true);
}
+ @TestTemplate
+ public void allManifestsTableDoesNotOverPruneWhenIgnoringResiduals() throws
IOException {
+ // Snapshots 1,2,3,4
+ preparePartitionedTableData();
+
+ Table allManifestsTable = new AllManifestsTable(table);
+ TableScan scan =
+ allManifestsTable
+ .newScan()
+ .filter(Expressions.equal("content", ManifestContent.DATA.id()))
Review Comment:
make sense, changed to
```
filter(Expressions.equal("content", ManifestContent.DELETES.id()))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
