zeroshade commented on code in PR #1850:
URL: https://github.com/apache/iceberg-go/pull/1850#discussion_r3814580957
##########
table/equality_delete_reader_test.go:
##########
@@ -142,6 +142,22 @@ func TestEqualityDeleteReadRoundTrip(t *testing.T) {
}
assert.Equal(t, []int64{1, 3, 5}, ids, "expected rows with id=2 and
id=4 deleted")
+
+ _, itr, err =
tbl.Scan(table.WithSelectedFields("data")).ToArrowRecords(t.Context())
Review Comment:
Non-blocking: since `id` is now read as an execution-only field, could this
retain the returned schema and assert that it contains only `data` (and that
each record has exactly one column)? That would make the no-hidden-field-leak
contract explicit rather than relying on `Column(0)` alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
