thswlsqls commented on PR #16871: URL: https://github.com/apache/iceberg/pull/16871#issuecomment-5338563561
@pvary Moved the fix to the caller side: `ArrowBatchReader` now builds a vector holding the column's value before the batch is assembled, so a column that isn't in the data file reads as a constant instead of failing. `GenericArrowVectorAccessorFactory` is back to what it was. Covered by `TestArrowReader#testReadColumnAddedAfterDataFileWasWritten` and a new `TestConstantVectors` (8 tests across every primitive constant type). I've updated the description as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
