sqd commented on code in PR #17618:
URL: https://github.com/apache/iceberg/pull/17618#discussion_r3806794247
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicSinkUtil.java:
##########
@@ -57,6 +57,11 @@ static Set<Integer> getEqualityFieldIds(Set<String>
equalityFields, Schema schem
*/
static Set<String> resolveEqualityFieldNames(
@Nullable Set<String> equalityFields, Schema schema) {
+ if ((equalityFields == null || equalityFields.isEmpty())
+ && schema.identifierFieldIds().isEmpty()) {
+ return Collections.emptySet();
+ }
Review Comment:
Thanks for the look! Comment added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
