fallintoplace commented on code in PR #1770: URL: https://github.com/apache/iceberg-go/pull/1770#discussion_r3798041349
########## manifest.go: ########## Review Comment: Fixed in bf054fbb3. - Removed `clonePartitionStatValue`. - Clone `[]byte` right after converting the value to `T`. - The min/max update code is simpler now and keeps the copied bound values. - `go test ./...`, the focused race tests, and `go vet ./...` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
