pvary commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r3795455364
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -114,6 +114,19 @@ protected boolean supportsBatchReads() {
return false;
}
+ protected boolean readOnly() {
Review Comment:
Please separate out the test to:
- ReadFormatModelTests as a base, and move the read tests there
- BaseFormatModelTests inheriting from ReadFormatModelTests
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -114,6 +114,19 @@ protected boolean supportsBatchReads() {
return false;
}
+ protected boolean readOnly() {
Review Comment:
Please separate out the test to:
- ReadFormatModelTests as a base, and move the read tests there
- BaseFormatModelTests inheriting from ReadFormatModelTests
I would do this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
