fallintoplace opened a new pull request, #1742:
URL: https://github.com/apache/iceberg-go/pull/1742

   ## What changed
   
   Use checked arithmetic when a manifest reader inherits `first_row_id` for V3 
data files. The reader now rejects:
   
   - a row ID range that exceeds int64
   - a negative data-file record count
   - a negative inherited starting row ID
   
   The next row ID is only updated after validation succeeds.
   
   ## Why
   
   The reader currently advances its row ID cursor with unchecked addition. A 
range near `math.MaxInt64` can wrap to a negative row ID and assign invalid 
lineage to later files.
   
   ## Testing
   
   - added overflow coverage at `math.MaxInt64`
   - added negative record-count coverage
   - `go test ./...`
   - `go vet ./...`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to