fallintoplace opened a new pull request, #1737: URL: https://github.com/apache/iceberg-go/pull/1737
## Summary `ExpireSnapshots` could remove snapshots and later garbage-collect their files even when the table property `gc.enabled=false`. This change: - rejects snapshot expiration when garbage collection is disabled - applies the guard before staging metadata requirements - keeps the behavior independent of `WithPostCommit(false)` - exposes the shared `gc.enabled` property constant and default - updates the cleanup documentation The error matches the current Iceberg Java implementation: `Cannot expire snapshots: GC is disabled (deleting files may corrupt other tables)`. ## Test plan - `go test ./... -count=1` - `go vet ./...` - `go test -race ./codec/... ./table/...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
